[No QA] Show Workspace Chat first instead of opening Global Create #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
changed the title
luacmartins
changed the title
luacmartins
commented
Feb 22, 2022
| @@ -113,7 +113,7 @@ const HeaderView = (props) => { | |||
| </Pressable> | |||
| </Tooltip> | |||
| )} | |||
| {props.report && props.report.reportName && ( | |||
| {Boolean(props.report && props.report.reportName) && ( | |||
There was a problem hiding this comment.
I added this to fix a RN error that I was seeing where text is a child of View
There was a problem hiding this comment.
I haven't seen it done like this, good thinking.
|
Can you please add test screenshots |
MonilBhavsar
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Simple change and looks good to me
@TomatoToaster could you please give this a quick review
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
69 tasks
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.40-0 🚀
|
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates the welcome actions to show the Workspace chat first instead of opening the global create.
cc @TomatoToaster
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/195473
Tests
accountIDandreportIDfor an existing account and chat.chatTypeof that chat topolicyExpenseChatby running the following query:UPDATE reportNameValuePairs SET value = 'policyExpenseChat' WHERE name = 'chatType' AND reportID = <reportID>;isFirstTimeNewExpensifyUserfor that user to true by running the following queryUPDATE nameValuePairs SET value = true WHERE name = 'isFirstTimeNewExpensifyUser' AND accountID = <accountID>;reportIDchat../script/clitools.sh generator:accountQA Steps
None, as Workspace chats are not available yet.
Tested On
Screenshots
Web
web.mov
Mobile Web
mweb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov